Mike Drob

This is kind of a pain, but I’d like to see the commits split into a clean fork and then our changes separately. Also, I don’t think we repackage the...

Thanks for the patch! Can you add a unit test demonstrating this failure? I think from there it will be easier to brainstorm a fuller solution in case you think...

See also https://github.com/apache/lucene/pull/1049 and LUCENE-10662

So after seeing your pointer to the DeleteBackupPayload class, I understand more of the intent, and I no longer think this is a worthwhile change. I'm sorry that you ended...

please also run `./gradlew tidy` to make sure that your code adhered to our formatting conventions. :)

I found your source `FastInvTrig` repo and ran the benchmarks from there, with a few tweaks to improve measurement accuracy and also added Lucene's [SloppyMath](https://javadoc.io/doc/org.apache.lucene/lucene-core/latest/org/apache/lucene/util/SloppyMath.html) into the competition. My results...

I'm a little confused as to what the sloppyAsin results are... From your tests, we should still prefer NVector with MacLaurian expansion at 17 terms over using Sloppy Haversine, right?...

Can we do a similar trick to split the calculation to get an n-vector sort key and an n-vector meters and get even more speedup for the cases where we...

Ok, I get it now. Yes, let's do the SloppyMath.asin approach, splitting out the sort key (I would call it dot product and add comments about why we can use...

It looks like something went wrong, maybe this branch is out of date? Can you check that it is current, I wanted to give it a final pass review but...