Madelyn Olson

Results 653 comments of Madelyn Olson

I don't want to offload the ping command. I feel like part of the job of the ping command is to determine the health of the server, so it could...

@zvi-code I believe you wanted to comment on this.

We believe this is a test failure, which is more important to fix before we go GA with Valkey 8.0.

I think we should keep it in the Valkey 8.0 board. The empty shard failover is a new feature, I think we should be tracking this as a fast follow...

@PingXie Are you still planning on owning this? Maybe we can make sure this is fixed as part of atomic slot migration improvements?

Sounds like a breaking change, so I think we'll need to maintain it for the new future until people adopt the new migration command.

@kyle-yh-kim Do you want to update this or should we close it?

@kukey I think it's worth evaluating in more detail, can you open a PR with your proposal and we can move the conversation more. I have many of the same...

> Deep dive into why the invalid state is reached (cyclic replication state). We have had multiple of these issues in the past, and I think we always tried to...

> And if we detect a loop, do we crash? Maybe we debug assert crash (as in only crash during a test). For normal production, we unwind we maybe ignore...