Madelyn Olson

I feel like we should at least bring up the performance degradation that was called out here: https://github.com/redis/redis/issues/9939#issuecomment-1017048533. The previous person to submit the PR didn't give percent degradation, but...

> I wonder if the differenxe is noticeable in a stream. I doubt it. We could run one with just xadd, xread, xtrim in valkey-benchmark. Yeah. I'm open to that....

Can you add more information on why you think this feature is useful? I see the one use case which is random sampling, but it seems OK to just do...

I'll throw it on the roadmap, I'm still not convinced it's the most useful of features though.

There was a previous PR in Redis where we discussed some log format: > Copied from a copy of Redis #12934, explicitly didn't include a reference to avoid having folks...

It's very timely for you to open this issue, we talked about this morning as thinking about revamping logs. Can you add a bit more context about what JSON format...

Correct, the only reason we moved it is we are approaching code cutoff for 8.1 and it wasn't implemented yet. If someone is interesting in contributing it, we can still...

Yeah, you have to create local variables. Someone might already be creating a local server that would shadow the global variable, but that shouldn't break their script. It is a...

(Assigning it to me, although someone else from AWS is working on it. I'll update assignment when they join the triage group)

Just to mention, this won't crash for most production users since it uses the debug assert.