Madelyn Olson

Results 699 comments of Madelyn Olson

``` " .+#+. \n" " .+#########+. \n" " .+########+########+. Valkey %s (%s/%d) %s bit\n" " .+########+' '+########+. \n" " .########+' .+. '+########. \n" " |####+' .+#######+. '+####| " |###| .+###############+....

> (I picked @ because it seemed more black than #, and I thought the b,d,q,p were funny as diagonals. This doesn't matter though.) I'm fine with @ to be...

I posted my attempt here: https://github.com/valkey-io/valkey/pull/251

For reference, this was discussed in https://github.com/valkey-io/valkey/issues/507. To recap my perspective. I was okay with allowing commands that aren't read-modify-write commands. Either pure writes (DEL, MSET) or pure reads (MGET)...

> We have use cases that we simply can't run without this so pretty important for very high scale jobs. One question we did want to understand was the actual...

> What was the rationale to not permit read modify write? It felt like it was logically breaking the abstraction, since we practically have serializability within a slot. To allow...

> so 1,886,792 keys/sec for SET vs 5,025,120 keys/sec for MSET. So 2.66x faster at the extremes. Another thing that was discussed was that we could use instruction prefetching or...

I was able to reproduce the test locally. It's a bit flaky. It seems like the migration is getting stuck somehow.

We're getting de-sync errors in the test: ``` 24786:S 19 Aug 2025 09:52:35.066 # Protocol error (Master using the inline protocol. Desync?) from client: id=32 addr=127.0.0.1:21116 laddr=127.0.0.1:61112 fd=25 name= age=11...

The major decisions: 1. Do we want to be able to support this downgrade. 2. How far back to we want to support restoring into older versions? (At least one...