Madelyn Olson
Madelyn Olson
@lipzhu I would keep this open. We may still want to apply the changed on `REDIS BUG REPORT END. Make sure to include from START to END` that this PR...
Thanks, we need to decide if this is a breaking change, putting it in the 8.0 project for the time being.
This isn't required for 9.0, but I would like us to try to get it merged after the 9.0 rc-1 goes out.
@uriyage Can you prioritize doing the merge so that we can properly run the tests?
(Ooops, didn't mean to approve, but I can't dismiss it while there are merge conflicts apparently?
> In addition, we won't offload commands if c->slot is not set (for example, in the KEYS command). This covers the case of multi-slot access. It would still be good...
I somewhat agree with Viktor. We can add a debugAssert to severassert.h if we want, that is just a no-op. I was also dubious of this PR, since it's just...
Couldn't they then just save the state? I agree, I feel like I would rather close this and re-open if that use case becomes public. I'm not sure what that...
@soloestoy Do you have any further followup?
``` " .+@+. \n" " .+@@@@@@@@@+. \n" " .+@@@@@@@@+@@@@@@@@+. Valkey %s (%s/%d) %s bit\n" " .+@@@@@@@@+' '+@@@@@@@@+. \n" " .@@@@@@@@+' .+. '+@@@@@@@@. \n" " |@@@@+' .+@@@@@@@+. '+@@@@| " |@@@| .+@@@@@@@@@@@@@@@+....