Madelyn Olson

I did mark it apparently. It looked like an issue we could add a configuration for. We could also just disconnect the client and stop looping if such an action...

> why is that issue any different than any other case of user attempting to read large amount of data (eg hgetall)? is that is because of a potential missuse...

100% of the TLS tests are still failing, those should be fixed before we merge this.

@xbasel We can close this right?

@lipzhu So I have a proposal to add some more type checking, which alleviates my concerns to prevent someone from misusing this API.

> Or we can introduce a new flag like write_ready in client structure, set write_ready = 1 before iteration and reset it after exit? We would have to reset it...

> Regarding the cleanup can't we do it in afterCommand flow once and guarantee the reset (not everyone needs to remember to do it). We could maybe do it in...

The code felt good, but I changed the wording to `writePreparedClient`, which felt a bit better. @lipzhu Will wait for you to ack that you think this makes sense then...

> Speaking of repl-diskless-load, do we consider adding an empty-db option? it perform a flushall at first so that we can take on-empty-db It's a little dangerous because it increases...

We'll make issues for each of these changes individually.