Madelyn Olson

Results 642 comments of Madelyn Olson

In the client info we have two extra pieces of information, the `name` and the `user`, we need to decide if this counts as user data and should also be...

@valkey-io/core-team Overall would like a vote for this. In addition, some specific questions for this feature: 1. What should the config name be. My recommendation is `hide-user-data-in-log` 2. Is the...

> username can be sensitive data, please reference function isSensitiveCommand (valkey-cli.c), which username, passpword, and sentinel-user are all sensitive I'm aligned with this. Let's remove the name and username from...

@naglera I think a bunch of tests are failing because we changed the default value, which is breaking a bunch of log scans for tests. I think for testing we...

This makes sense to me @soloestoy Do you know of any use case where this would cause an issue. Multi-exec with script load should fail. I guess it's a breaking...

I suppose I realized one case this might fail. If someone is trying to load a script that cleans up data, it might fail unnecessarily. There are also previous cases...

> Maybe we can take a different approach by adding maxmemory-scripts to limit the size of cached scripts. It would only be allowed to use a certain percentage of maxmemory,...

> I have seen many instances where number_of_cached_scripts reaches the million level, and used_memory_scripts_eval consumes tens of gigabytes of memory, lol. When a feature is unrestricted, it is prone to...