Thomas Li

Results 175 comments of Thomas Li

You can just push to my PR directly if you want, or pull the changes here. It's a little farther down the pipeline, but I will not have time to...

FYI Windows will also fail until #47467 is merged in.

@fangchenli Thanks for picking this up. There haven't been commits on this PR in a while, so I was wondering whether you had the time to finish this PR up....

I accidentally pushed some commits here(I misconfigured github cli-meant to push to my own branch and pull request to this one), so I decided to go all the way to...

> @lithomas1 Thank you very much for finishing this up. Thanks for picking this up again.

OK, this works now. We should probably specify a minimum tzdata version too, though. @jbrockmendel Do you have anything in mind?

Zoneinfo is also kinda wonky, since it doesn't really need the tzdata package, just a copy of the IANA tz database. I'm not sure we have a way to check...

This is blocking #47442, so we should probably merge this now, and open an issue to discuss tzdata version, since there is not yet enough consensus on that.

OK, so I've updated this PR again. It's too difficult/costly to check the version of the system IANA tz db if present, so we're just going to specify a minimum...

I'm going to self merge this in a couple of days if no other comments, so we can get the Python 3.11 testing in.