Thomas Li

Results 212 comments of Thomas Li

Planning on holding off on this until setuptools is completely gone.

I'll take another look - thanks for the reminder.

OK, this POC kinda works now. The way it works is by excluding the tests from the sdist(via .gitattributes), and then building the wheel from that sdist. Since the tests...

In terms of savings, for the Windows wheels uploaded, it's like 2MBs (the originial is like 12.2 MB, and the one without tests is like 10.2 MB). I didn't measure...

@pandas-dev/pandas-core Thoughts on whether this would be worth it?

Finally green here 😌 Anyone want to take a look? (NOTE: The diff is only big because I split the doctest stuff out of conftest. Actual changes are only ~200...

> Hey! > > Thinks this is a decent idea. > > How much does this decrease the dist size by? Would be good to know that before merging this...

> I think now it may be important to run the wheel build job on PRs again since more PRs will be updating `pandas` and `pandas_tests` and we need to...

@pandas-dev/pandas-core any other feedback? I'd like to merge this in otherwise.

> Nice work, but I'm pretty lukewarm to the implementation. Seems like there are a lot of potential break points and CI is not the easiest to debug. > >...