Thomas Li

Results 212 comments of Thomas Li

> How does that compare to just running `ninja` directly? It shouldn't be taking much longer than that, and this is something we can't really do much about. Using `Traversable`s...

> > This needs docs before landing, though, so I am going to block this. > > What exactly are you looking for in the docs? The next big item...

I don't have time to test this this week, so I'm just going to assume that if it works for scipy, its probably going to work for pandas.

Hmmm. I think I would lean more towards keeping the default as a release build, with a command line option to toggle. Wheels are meant to be distributed, and having...

I would really prefer meson-python test pandas, instead of the other way around. I don't think meson-python's coverage is very good right now(FFY00/meson-python#120 is a good example of this, where...

@Vysybyl We use cython for the corr code not C++. The relevant code can be found here. https://github.com/pandas-dev/pandas/blob/84d9c5ed7965b3cc667b5a3a61d5911b1748af49/pandas/_libs/algos.pyx#L324

I think that you need to compile against the lowest version of numpy supported in the wheels, since the C API is forwards compatible not backwards compatible. This is what...

Yeah, I'll probably change the name to PDEP-15 once I get around to moving this to a separate PDEP (probably tomorrow). I was travelling the past week, so didn't really...

Thanks for the reminder, this slipped off my radar. > My vote on this will heavily depend if we can come to an agreement on PDEP 14 Yeah, ideally, we'd...