Thomas Li
Thomas Li
I made a draft PR here https://github.com/lucascolley/scipy/pull/14 (I'll add some more comments/insights on why I changed what lines of code later) Could you pull main on your branch later if...
Apologies for the long silence here. I did some digging into the remaining fft/special failures and other than some small issues with extra warnings coming from dask, I think I...
Now, I should have all of fft/linalg/special passing. stats looks do-able, the main changes seem to be silencing/ignoring the RuntimeWarnings from dask and figuring out how to make ``_lazy_where`` not...
> thanks @lithomas1, I rebased on main here. The CI log is quite messy due to an error in `TestLazywhere` in `_lib.tests.test__util`: Thanks for the update. I've attempted to cherry-pick...
> @lithomas1 any update on this? Planning on circling back since the dask PR is merged now.
I think we said this PR was good at the perf tools meeting 2 weeks ago, but requesting another review/pair of eyes just to be safe.
Thanks for the review, and sorry for the slow reply. I addressed the device issues (a MPS run on my Intel MBP uncovered some more issues that I fixed).
Added some more tests. I think this should be ready for another pass now. Thanks for the reviews!
Sorry for the slow reply, I switched to using a different laptop for open source stuff. > Thanks @lithomas1 ! This looks good, I just had some nits and a...
Ugh looks like something weird going on with precision for cupy. Is it OK to just skip the test for cupy (this isn't ideal, but we have some confirmation the...