Ismail Khoffi
Ismail Khoffi
~~Is this still relevant? I think @Wondertan went and did this in node anyways?~~ Moved over to node.
Are we still planning to move this into a separate repo? I think for now we are fine with this living in node (instead of core). Should we close this...
ref: https://github.com/celestiaorg/celestia-node/issues/656 I think we can close this for now. Feel free to re-open if needed.
Key metrics of the top off my head: - measure sampling time - measure BlockSync time (per block and in total from height h, where h could be 0/genesis) for...
This is also related to https://github.com/lazyledger/lazyledger-core/issues/87 as DA validation will be done by some validators to decide on a block proposal.
Referencing this here as it is highly related: https://github.com/celestiaorg/celestia-node/pull/244#discussion_r761576295
And this: https://github.com/celestiaorg/celestia-node/pull/244#discussion_r761422429
@adlerjohn you are right. It can be avoided today. See https://github.com/celestiaorg/nmt/issues/55#issuecomment-1118931841
I think that is fine as long as readability always has priority over the optimal memory layout.
I've updated to the latest test-suite and made the build pass again: https://github.com/liamsi/go-libp2p-quic-transport/tree/transport-test-updated The tests fail locally but with other fails than `StressTestTimeout (60s)` (or at least I don't see...