Ismail Khoffi

Results 235 comments of Ismail Khoffi

> Should we rename the `DefaultPolicies` to `ConiksPolicies` to avoid misunderstanding? Makes sense to me.

This is a bit off topic but maybe it could be interesting to see if we can bind multiple names to one main-name / identity / key? Maybe this could...

As far as I remember this was discussed quite a while ago and we've decided to reuse [HashSizeByte](https://github.com/coniks-sys/coniks-go/blob/5e626ab2f2610256d328c1273b3cf26f68e762aa/crypto/util.go#L12) for simplicity (not introducing another constant) and some extra-bits of security. Another...

@c633 Currently, the `TreeID` is generated here: https://github.com/google/trillian/blob/9d527702a6bcb53cc11fa5d2b99a115bf2d3c353/storage/tree_id.go#L23-L30

As I did some moving around of test code, I could take care of this. Does it make sense to start this soon? I would create a (possibly internal) `testutils`...

> We should also be thinking about to what extent that needs to be true and looking for ways to remove that property from the system. I imagine even an...

See also: https://github.com/coniks-sys/coniks-go/issues/16#issuecomment-236861534

Just noting that a few other diagrams are also missing. I've tried to regenerate the PDF using pandoc to read the entirety of the spec on a tablet and got:...

ref: https://github.com/tendermint/amino_rs/tree/debugging_issue28

> I believe @Liamsi created a fork. Yeah, I wanted to avoid maintaining a fork for various reasons... Will create a separate repo instead (tmrw), cherry-pick changes from @tarcieri and...