Ismail Khoffi

Results 235 comments of Ismail Khoffi

I like @gdbelvin's idea. It makes it easier to sync up and might increase compatibility. Be aware that the interface described in google/trillian#670 isn't fully implemented yet (but will be...

> @Liamsi Thanks for the awesome work. I'd like to take this forward. Please can you elaborate a bit on these points of your checklist Unfortunately, I do not remember...

> I have a working prototype but is it a little dirty because with TCP you handle manually the sockets (listening, accepting and handling) but with HTTPS server it is...

Thanks for your reply. And no problem. I was just curious.

The SDK is about to remove / [reduce](https://github.com/cosmos/cosmos-sdk/pull/9355) (?) the multistore because it is not easy to implement this correctly I think. See specifically this comment: https://github.com/cosmos/cosmos-sdk/issues/6370#issuecomment-643226398 (the problem is...

By key version numbers you mean sth. like having counters in the leafs for different key versions, right?

Thanks! Hmm, interesting. So basically, yes, this is a counter. The second idea is storing all different versions of the key in the leaf-node. Do you know if there is...

> It should be paired with #134 . I changed its milestone to 0.2.0. Yes, I think that's reasonable! Thanks.

From my point of view this PR looks very good (just a few questions and nitpicks).

This might be related: https://tip.golang.org/pkg/plugin/ (investigate if protocol extensions could be build as optional plugins)