Ismail Khoffi

Results 235 comments of Ismail Khoffi

Looking through the paper that describes the encode and `ReedSolomonEncode` it seems like the code reads mostly like a straightforward implementation of this: ![image](https://user-images.githubusercontent.com/7441766/81747777-fb509400-94a8-11ea-8e3a-e77d0de9ec0e.png) Source: https://www.citi.sinica.edu.tw/papers/whc/3450-F.pdf So with that notation,...

I think we (or mainly @musalbas) figured it out: if the number `k` is 256 then the recovery bytes will be `2k` instead which seems to be a property of...

Well, actually this is not the case (this is independent from ff8 or ff16): `leo_encode_work_count` always multiplies the next power of 2 of recovery count by 2: https://github.com/catid/leopard/blob/b58d1eaf59e263d25e473a3460437e19386956eb/leopard.cpp#L102 So e.g....

A few remarks: > It seems like this can be done purely on the Cosmos SDK side, by appending intermediate state roots to transactions. I don't think this works. E.g....

I'm not sure why we would need to hotload code via a container as @zmanian mentioned 🤔 It seems to me the problem of connecting different chains with each other...

I do think adding a byte on a per share level for very specific edge-cases is a optimizing for the wrong thing. But if this is a strict requirement, then...

> backwards-compatibility for on-chain smart contracts @musalbas: smart contracts can be upgraded, right? > programs that need to parse the shares but are not upgradeable Maybe we should not design...

This can be split up into the following steps (of which some can and should be worked on in parallel): 1. make the preprocess step for block N return the...

Any specifics which tests we want to see? Sth. I would like to see is a check to circleci to check if the proto files were modified and the dev...

I thought this has changed in the cosmos-sdk? And the 20 bytes are only used for backwards compatibility? @adlerjohn: https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-028-public-key-addresses.md Note that the node-id is likely not affected by that...