celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

Published 20 hours ago • verified publisher icon celestiaorg

ipld: Extract IPLD plugin into separate repository

Open Wondertan opened this issue 3 years ago • 5 comments

Goal

For ShareExchange and DASing to work we need to use IPLD implementation of NMT, which is currently located in Core. The Node needs to use it as well, so we need to extract the plugin with supporting functions into a separate repo to be used by both Core and Node repos.

Actions

  • [ ] Create new repo #111
  • [ ] Cherry-pick plugin and ipld package from https://github.com/celestiaorg/celestia-core/pull/427
  • [ ] Define what logic should be in the repo and what should be part of Node repo.
  • [ ] Update core and close https://github.com/celestiaorg/celestia-core/issues/296
  • [x] https://github.com/celestiaorg/celestia-node/issues/114

Wondertan avatar Aug 20 '21 09:08 Wondertan

@Wondertan can you make the first action item link to #111 ?

renaynay avatar Oct 18 '21 10:10 renaynay

Are we still planning to move this into a separate repo? I think for now we are fine with this living in node (instead of core). Should we close this and revisit once a need arises?

liamsi avatar Apr 14 '22 21:04 liamsi

@liamsi post mainnet likely

renaynay avatar Apr 27 '22 11:04 renaynay

ref: https://github.com/celestiaorg/celestia-node/issues/656

I think we can close this for now. Feel free to re-open if needed.

liamsi avatar Apr 27 '22 14:04 liamsi

Grooming 12/07/2022:

  1. Moving to Post-Mainnet
  2. Extraction should be done after #878

Bidon15 avatar Jul 12 '22 14:07 Bidon15

Grooming 01/11/2022:

There is no reason to follow-up/track this issue due to a different approach and core/app won't use it

Bidon15 avatar Nov 01 '22 15:11 Bidon15