Ismail Khoffi

Results 235 comments of Ismail Khoffi

Exactly, we would include the validator set root in both the header and folded into the state. > Which would make this issue no longer needed until we eventually remove...

> as an example that the rpc works @Bidon15 your curl command does not work for me either. but looking at the error you shared this indicates that node is...

> What makes this endeavour done: Node binary accepts 2 new flags, like --core.grpc.endpoint=grpc.whatever.io and --core.rpc.endpoint=rpc.whatever.io @Bidon15 btw the right solution to this problem is not adding more flags to...

> Introducing BlobModulev1 that will support new features: I am not sure where the v1 versioning will be applied but note that I'd like to reserve v1 for semantically versioning...

I still think versioning a module in an internal API as v1 while a broader public v1 API is in the works and also be published will be confusing. Why...

> do we want to be able to submit blobs in both modes(sync/async); I think both are needed. Would be good to check with users though.

> Therefore, blob.Get should utilize txHash instead of height to identify the blob Do we have an idea how this can be implemented? I would assume that it is fairly...

> Api version and software versions arent the same. Yes, absolutely but they actually are if they are meant to be consumed internally by the software (e.g. cli) itself.

For a fix, see: https://github.com/celestiaorg/celestia-app/pull/2014

> Any suggestions for better names @renaynay @adlerjohn @liamsi? Yeah, I also raised this somewhere else. So ideally: - anything shares related would be folded into the shares "module" -...