Ismail Khoffi
Ismail Khoffi
> As the square already contains the underlying data true > it is an unnecessary allocation of memory to also store the entire data in the leaves while I agree...
What is wrong with the existing verify method? I think this was implemented even before the spec defined this. https://github.com/celestiaorg/nmt/blob/1d72cffd9fb40ecea93660be2e19ca3c1ecea53f/proof.go#L209 > This function should take (i) a NMT root of...
I think what is missing in the specs is a range proof [for the whole namespace](https://github.com/celestiaorg/nmt/blob/1d72cffd9fb40ecea93660be2e19ca3c1ecea53f/proof.go#L99) which is needed for what is called application proofs in the LL paper. IMO,...
This is interesting. In the past the Push method used to have these already separated: https://github.com/celestiaorg/nmt/blob/6e8a6a5ec3fcae4015ca5dd1923ce033a0458679/nmt.go#L254 We can revert to that! Back then there was a lot of discussions around...
After discussing with @Wondertan, we realized that https://github.com/celestiaorg/celestia-node/issues/183 can be tackled without modifying the NMT library at all (and instead by modifying this [visitor](https://github.com/celestiaorg/celestia-node/blob/ed4cdf03f2bd35c30d5b9874d4bc40bea6f5a061/ipld/nmt_adder.go#L34)). So we could put this on...
> the older version of the state is no longer available on disk If you do not keep around at least some older versions (e.g. every X heights), you would...
@cwgoes @jackzampolin can you help us understand the requirements regarding querying past state in the context of IBC? Ethan Frey mentioned on discord that you (Jack) ran into some issues...
Yeah, I was also confused about this. Either these default param changes can be made directly in core, or, in app. App is the best if feasible 👍🏼
Essentially the same work (_minus_ removing the additional validator roots in the header), need to happen in optimint. @tzdybal I'd open a separate issue there and link to this and...
I'm not sure tbh. If we can keep the current mechanism _and_ have the validator sets as part of the sub-trees in the SMT as in the specs, that could...