Ismail Khoffi

Results 235 comments of Ismail Khoffi

Related to this @Wondertan also brought this draft / write-up (?) to my attention: https://math.mit.edu/research/highschool/primes/materials/2018/Kuszmaul.pdf It analyses bandwidth requirements and shows how to significantly improve on bandwidth while slightly increasing...

Yes, that would be ideal! Thanks for the comment.

> don't have enough rights to set labels/project we should change that. The labels here are not really set up properly yet anyways. Regarding project/priority: I set this to devnet....

> Implementing a similar 2D bitmask like the one in the repo and parts of crossword solving logic. We could simply export that logic and use it from several places....

I think both options existed in the past. See: https://github.com/celestiaorg/nmt/blob/dd6191cefbd34c84615afdab3859c6739c8c6e93/namespace/data.go#L3-L6 (I think I've never pushed the other version). I am not sure what the rationale was to make it just...

I would try the folllwing fwiw. Change these appends https://github.com/celestiaorg/nmt/blob/564300aaa2125d5881ecf62f024a22db190db17c/hasher.go#L190-L192 to ```go minMaxNIDs := append(append(make([]byte, 0, resLen), nID...), nID...) ``` and see if that removes the need for additional allocs....

Also, it is important to use benchstat for any related changes (since we disabled go-bencher recently): https://pkg.go.dev/golang.org/x/perf/cmd/benchstat Should include both mem and CPU.

This could be somewhat related: https://github.com/celestiaorg/nmt/issues/212

Revisiting this issue: we are already able to store the inner nodes on ipfs/the ipld merkle dag via that visitor I've added (see for instance the PRs that Evan added...