Ismail Khoffi

Results 235 comments of Ismail Khoffi

> Wow cool. Do you think Dedis might be interested in collaborating on Amino ? Not sure, but I can ping @bford @ineiti. And definitely, that would be great! I...

> Just noticed that the dedis code is GPLv2. Any chance we can change that? Interesting, I though we switched everything to GPLv3 (as it allows patenting and is more...

Thanks @patrickwieth!

Are we sure this is a non-issue? The line count has changed since then. I can't verify this by looking at line 273 I think.

The panics here are to make clear the this API is not intended to be used like this. But yeah, retuning an error (and the documentation etc) should do the...

We also sometimes cast `uint64` to `int` which behaves differently on 32 bit machines. This could lead to an unexpected panic, potentially posing a security issue: > the unsigned 64-bit...

I'm definitely in favor of using the Cosmos-SDK upgrade module, if feasible. Even if that means some tradeoffs. https://github.com/cosmos/cosmos-sdk/blob/master/x/upgrade/spec/01_concepts.md Otherwise, it will cost us time spec this out and implement/execute...

ref: https://github.com/lazyledger/lazyledger-specs/issues/171

This is still relevant independent of the specs we need to make a decision here and have a proper plan.