Ismail Khoffi
Ismail Khoffi
It sounds like there is no consensus around if we should unify SubmitPayForBlob and SubmitPayForBlobWithOptions and fold them into one method. My opinion: - if we were pre-launch and no-one...
So currently we already have two methods to submit blobs: - `Blob.Submit(blobs []*blob.Blob, gasPrice blob.GasPrice)uint64perms: write` - `State.SubmitPayForBlob(fee state.Int, gasLim uint64, blobs []*blob.Blob)*state.TxResponseperms: write` Not speak of the infamous `SubmitTx(tx...
Yeah, the functionality was moved to Clef (also linked above).
This is issue is really painful to read. @Wondertan @vgonkivs Golang semantics have little to do with JSON-RPC APIs. Please, help the team with either 1) how to handle the...
good point @rickyyangz. Did you you re-benchmark with your suggested changes? I would assume the performance to still be much slower than generated protobuf.
Hmm, amino does't try to be fully compatible with the standard json library but rather with the behaviour of protobuf/jsonpb. So how would embedding a struct in protobuf look like?...
That's pretty cool! I didn't know you can do this so easily (escape analysis). Even if we don't have any numbers on how beneficial it will be, it should be...
Sounds like a good idea! Did anyone compare how objecthash-proto deals with this? https://github.com/deepmind/objecthash-proto As we want to be as compatible to proto3 as possible, it might be worth looking...
I agree, this should be the default behaviour. And you are right, that proto3 doesn't encode the length by default. Length delimiting is used for [streaming] AFAIK. I think some...
First step (rename MarshalBinary) was addressed in #222. Will update depending projects to use the new API. After that we could either rename `MarshalBinaryBare` to `MarshalBinary`, or, we could keep...