Ismail Khoffi

Results 235 comments of Ismail Khoffi

Note: @mossid also suggested that the message could also look like this (to make sure the prefix bytes are indeed just 4 bytes). ```proto message BytePrefixedAny { sfixed32 prefix =...

I still vouch for the simplest form here from https://github.com/tendermint/go-amino/issues/267#issuecomment-492241358 ```proto message BytePrefixedAny { bytes amino_prefix = 1; // the amino prefix bytes (default will be 4 bytes but this...

That's absolutely right. What I meant was that it does not waste more bytes than necessary, e.g. compared to the separate encoding of pre- and disfix, like described here: https://github.com/tendermint/go-amino/issues/267#issuecomment-492255031,...

> I first want to address this 4 vs 7 prefix bytes issue. The current implementation uses this and RegisteredAny in protocolbuffers/protobuf#276 uses the same design. I find this design...

Looks like ibc-go is getting close to be released (with a 0.46 compatible version): https://github.com/cosmos/ibc-go/releases/tag/v6.0.0-rc1 We should sync with the IBC team before using that during the incentivized testnet though.

Closing in favour of https://github.com/celestiaorg/celestia-app/issues/169 and https://github.com/celestiaorg/celestia-app/issues/669 as these are more specific and actionable. Genesis params + using the cosmos sdk sufficiently define the genesis block. We can open a...

Additionally, later adding a few links for different frontends would be cool. Dropping some links here: - https://www.figment.io/resources/how-to-multi-sig-on-cosmos - https://safe.serenity.aura.network/ or https://github.com/aura-nw/Aura-Safe - https://github.com/informalsystems/multisig By the time we actually document...

btw yearn has a similar feature: https://github.com/banteg/yearn-vesting-escrow/ specifically: > An ability to terminate an escrow and clawback all the unvested tokens using rug_pull. The recipient is still entitled to the...

Would it make sense to upstream this implementation? https://github.com/agoric-labs/cosmos-sdk/pull/155

resharing this here as it also seems related: https://github.com/cometbft/cometbft/blob/4241776d5c2a73f19d63b7627a11af643a3fe6a8/docs/references/architecture/adr-115-predictable-block-times.md