Ismail Khoffi
Ismail Khoffi
related: https://github.com/tendermint/go-amino/issues/154#issuecomment-392421945
Also, everything beyond the generic authorization should be accompanied with a test. re: - https://github.com/celestiaorg/celestia-app/pull/1540#pullrequestreview-1359416990 - #1541
You would need to register `interface{}` using `(*interface{})(nil)` like this: `cdc.RegisterInterface((*interface{})(nil), nil)`.
Here is a more complete example: ```golang type MapI struct { MAP map[string]interface{} } type Foo struct { Int int } type Message interface{} m := make(map[string]interface{}) m["one"] = 3...
removed from the [proto milestone](https://github.com/tendermint/go-amino/milestone/1): My understanding is, we require everything amino encodes can be represented as a protobuf message and not that amino supports every proto feature.
I'm not sure I understand what you mean by `types`. Do you mean a package like this: https://github.com/tendermint/tendermint/tree/master/types ? If not, could you provide an example?
I don't feel so strong about the `types` that I would call it an anti-pattern. But I do agree with every concern @xla raises above. As someone who is new...
I think this change makes sense as is. But I originally thought that there is a way to only recompute the required shares and I also thought that is what...
> Leopard is pyramid encoded, so several layers are needed to reconstruct a bottom shard. It's been too long since I looked into leopard myself and I don't fully understand...
If you look at the paper, what I mean is that you should be able to save computations by simply not adding missing shard positions to the set E if...