Ismail Khoffi

I think it is important that we have a way to compare performance, e.g. if we are trying to recover a single shard as required. Otherwise we don't know if...

Let me try if what I wrote above (inspired by the paper that is the basis for leopard) and see if only adding required shards to the error bits, breaks...

As discussed with @marbar3778 the changes here pose a problem when bechifying the consensus pubkey in the SDK: https://github.com/cosmos/cosmos-sdk/blob/f1adb7afd974ee50ac9ac83a315cde932f47d7ef/x/staking/types/validator.go#L181-L182 creates a too large string (92 bytes) which can not be...

There seems to be another bug in the changes here. Add this test (in types/address_test.go in the sdk for instance): ```go func TestValAddrMustMarshal(t *testing.T) { var pub ed25519.PubKeyEd25519 tSlice :=...

The latter might be somewhat related to: https://github.com/tendermint/go-amino/issues/272 In `UnbondAllMatureValidatorQueue` the `timeslice := []sdk.ValAddress{}` is implicitly of type `[][]byte` (ValAddress is just bytes). But this should (and previously did) work...

The problem here is that the chain_id currently is not send around between the kms tendemint. So both sides currently do not know of the other's chain_id (hence can't check...

@ValarDragon do we need this pre-launch? Looks like we have a workaround in tendermint.

Thanks for reporting this! I always thought there must be some edge cases where amino still behaves slightly differently than protobuf. Do you mind sharing the .proto files with us?...

Amino allows you set a flag per field (`amino:"empty_elements"`) which will disallow `nil` in repeated fields (with `nil struct pointers not supported when empty_elements field tag is set`). Maybe we...

> If I understood correctly, you're keeping both hand-written Go structs and protobuf-generated Go structs? That is the idea, yes. > Wouldn't it be better to use protobuf-generated structs where...