yarn
yarn copied to clipboard
Try to migrate to mapping io
Still needs stitch for jar merger and rewrite intermediary after #2708
The product mapping file is smaller due to mapping io skipping over meaningless mappings (e.g. ignore wholesale when named, intermediary, official are all same, skipping named when it does not differ from intermediary)
removed a few useless tasks and antique import/export mappings for official -> intermediary migration for yarn
@modmuss50 In case you are interested, this is a diff between the old and new tiny v1 outputs: https://gist.github.com/5c15be78d81efd0c79ba8843fe65edcc it omits the entry if 3 names are the same and omits the named column if it's same as intermediary
Drafting as I will base this on #2708; waiting for it to get merged first.
Current diff for v1 after sorting: https://gist.github.com/liach/50efe22a6aa24bf0087bca77f2b6df32
For v2, sorting is more complex. In addition, sorting probably should be done in mapping io; see https://github.com/FabricMC/mapping-io/issues/9
The product mapping file is smaller due to mapping io skipping over meaningless mappings (e.g. ignore wholesale when named, intermediary, official are all same, skipping named when it does not differ from intermediary)
I wonder if that makes it do the same as loom: FabricMC/fabric-loom#506
Fyi I will put this on hold given mapping-io's lack of ability to sort the mapping tree. The lack of auto name propagation to other namespaces is a minor issue too.
Sorting isnt a big issue IMO, other than beign easier to diff the output, its not a major issue.
Busy recently (so am not reviewing and submitting or even fixing my own prs). Will take some time to work on a better diff generator beyond text editor java programs once I am free.
🚀 Target branch has been updated to 1.18-pre8
🚀 Target branch has been updated to 1.18-rc4
🚀 Target branch has been updated to 1.18
Can be closed now, right?
Yes, I the next thing to do will be to remove the old code and also fix the perf regression when saving (something I started looked at)
Thanks for reminding me to close outdated pull requests :+1: