yarn icon indicating copy to clipboard operation
yarn copied to clipboard

Try to migrate to mapping io

Open liach opened this issue 2 years ago • 10 comments

Still needs stitch for jar merger and rewrite intermediary after #2708

The product mapping file is smaller due to mapping io skipping over meaningless mappings (e.g. ignore wholesale when named, intermediary, official are all same, skipping named when it does not differ from intermediary)

removed a few useless tasks and antique import/export mappings for official -> intermediary migration for yarn

liach avatar Sep 25 '21 03:09 liach

@modmuss50 In case you are interested, this is a diff between the old and new tiny v1 outputs: https://gist.github.com/5c15be78d81efd0c79ba8843fe65edcc it omits the entry if 3 names are the same and omits the named column if it's same as intermediary

liach avatar Sep 25 '21 12:09 liach

Drafting as I will base this on #2708; waiting for it to get merged first.

liach avatar Sep 27 '21 01:09 liach

Current diff for v1 after sorting: https://gist.github.com/liach/50efe22a6aa24bf0087bca77f2b6df32

For v2, sorting is more complex. In addition, sorting probably should be done in mapping io; see https://github.com/FabricMC/mapping-io/issues/9

liach avatar Sep 29 '21 00:09 liach

The product mapping file is smaller due to mapping io skipping over meaningless mappings (e.g. ignore wholesale when named, intermediary, official are all same, skipping named when it does not differ from intermediary)

I wonder if that makes it do the same as loom: FabricMC/fabric-loom#506

Juuxel avatar Sep 29 '21 14:09 Juuxel

Fyi I will put this on hold given mapping-io's lack of ability to sort the mapping tree. The lack of auto name propagation to other namespaces is a minor issue too.

liach avatar Oct 03 '21 11:10 liach

Sorting isnt a big issue IMO, other than beign easier to diff the output, its not a major issue.

modmuss50 avatar Oct 17 '21 14:10 modmuss50

Busy recently (so am not reviewing and submitting or even fixing my own prs). Will take some time to work on a better diff generator beyond text editor java programs once I am free.

liach avatar Oct 18 '21 01:10 liach

🚀 Target branch has been updated to 1.18-pre8

github-actions[bot] avatar Nov 24 '21 15:11 github-actions[bot]

🚀 Target branch has been updated to 1.18-rc4

github-actions[bot] avatar Nov 29 '21 15:11 github-actions[bot]

🚀 Target branch has been updated to 1.18

github-actions[bot] avatar Dec 01 '21 02:12 github-actions[bot]

Can be closed now, right?

NebelNidas avatar Apr 06 '24 13:04 NebelNidas

Yes, I the next thing to do will be to remove the old code and also fix the perf regression when saving (something I started looked at)

modmuss50 avatar Apr 06 '24 13:04 modmuss50

Thanks for reminding me to close outdated pull requests :+1:

liach avatar Apr 06 '24 14:04 liach