Joe Lencioni

Results 248 comments of Joe Lencioni

Hi @travel-idealo, thanks for the PR! I'm a little hesitant to expand the API of this project. Could you share some more details about your use-case?

Aphrodite uses inline-style-prefixer for prefixing styles. It looks like they have a test that ensures that these values are prefixed. https://github.com/rofrischmann/inline-style-prefixer/blob/23d1c63b7b32c1b6ccf05f9d50b2a050766befd9/test/static/createPrefixer-test.js#L153-L158 What version of Aphrodite and inline-style-prefixer do you have...

Can you verify that this is still a problem for you on the latest versions of each? Aphrodite is at 1.2.1 and inline-style-prefixer is at 3.0.6. As for a repro...

> Beyond lib defs are there other reasons why we'd want to switch? More people are familiar with TypeScript, so switching will make it easier for those folks to contribute...

We do this in react-with-styles-interface-aphrodite. https://github.com/airbnb/react-with-styles-interface-aphrodite/blob/e9c088d8998bed347ff5c26f54a22d8dfd633cb6/src/utils/separateStyles.js Can you make a case for adding it to this project vs a separate project or something?

Sure, might as well I guess. Want to submit a PR? It would be great if your PR refactored any internal code that might benefit to also use this function....

It's true, we have that in the documentation. Perhaps we should remove that for now, or modify this to be a proper decorator. @droganov would you be interested in opening...

I don't have the code in front of me right now, but IIRC, it was something along the lines of this (simplified): ``` js ``` The JS in my-app.js renders...

In general this sounds like a pretty good start to me. I think it probably needs to include a couple of other things, like maybe: - the async nature of...