Joe Lencioni

Results 248 comments of Joe Lencioni

I think the snapshots would be a great fit for a lot of the current unit tests in particular.

I think this would be up to the specifics of the underlying interface you are using. If you are using the aphrodite interface, this might just work for you out...

I think it might be hard to say without more context. e.g. what is executed before the rehydrate call? Can you put together a repo that reproduces the issue?

To clarify, you would expect this to return the value of the `_definition` key?

I think I feel similar to https://github.com/Khan/aphrodite/issues/306#issuecomment-373825834 about this

I'm not convinced about that the value is worth the additional code complexity here. For normal properties, being able to convert from camelCase to kebab-case is really useful to make...

That page appears to be outdated. The readme is a better resource for you at this time https://github.com/airbnb/react-with-styles/blob/master/README.md

@majapw it looks like that string manipulation approach is no longer a thing. Is that right? **If this is no longer a thing** do you think making this change would...

Thanks for the report! I'd be happy to review a PR that fixes this.