Joe Lencioni comments

Results 248 comments of


                                            Joe Lencioni

Bump qs from 6.5.2 to 6.5.3

@dependabot rebase

Bump minimist from 1.2.5 to 1.2.8

@dependabot rebase

Bump ansi-regex from 4.1.0 to 4.1.1

@dependabot rebase

Add pagination to all pages that show past N request

Pagination in MySQL is very straightforward with the LIMIT syntax, but for MSSQL, things get a bit more complicated. I've written some functions that work to mimic the limit syntax...

PHP Error Notices - Undefined index when PHP is run from the command line

Yeah, running PHP from the command line typically doesn't happen for us except for cron jobs. You could either determine if it is being run from the command line and...

PHP Error Notices - Undefined index when PHP is run from the command line

Also found Undefined index: REQUEST_URI in utils/xhprof_runs.php on 424

PHP Error Notices - Undefined index when PHP is run from the command line

I'm thinking that if REQUEST_URI doesn't exist, you might be able to substitute $_SERVER['PHP_SELF'] which would be the path of the file that is being run.

PHP Error Notices - Undefined index when PHP is run from the command line

Also found Undefined index: c_url in xhprof_html/index.php on 167 Undefined index: timestamp in xhprof_html/index.php on 171 when requesting /xhprof_html/?hit=50&days=1

[Bug]: Parameter with function as value is not available in Manager API

> you can choose to override it with [channelOptions.allowFunction](https://storybook.js.org/docs/api/main-config/main-config-core#channeloptionsallowfunction). It looks like the `allowFunction` was removed here https://github.com/storybookjs/storybook/pull/30998 as part of the v9 release.

WIP Add support for newer versions of react-dom

I'm running into some issues with the tests. It seems that root.render triggers some asynchronous things that may happen later than the previous way of rendering (e.g. componentDidMount or useEffect)....