Joe Lencioni
Joe Lencioni
@limitedmage can you see if this is still an issue with 1.2.0?
@tolmasky you might want to consider not passing classes and styles between components entirely. Here's an article that outlines why and some strategies you can employ: https://brigade.engineering/don-t-pass-css-classes-between-components-e9f7ab192785 Although the article...
I think we can close this out.
> Do I understand it correctly that what remains on this issue is to validate the values of correct fields? That sounds about right > I've used Yup (joi) for...
It looks like there are some tests that expect for type checking to be running here. I'm happy to remove those tests if we want to go in this direction,...
We run the type checking outside of the critical path for our tooling. This gives us the safety of TypeScript without slowing down our tools very much. In CI this...
I'm terribly sorry but I don't think I understand what you are asking. Can you please clarify?
Thanks for clarifying, that was very helpful! Oh yeah, for sure using the JSDoc type annotations is a worthwhile option. However, they are not as expressive as the TypeScript annotations,...
I don't know if this is still true, but last time I checked, performance was better in Aphrodite.
Looks good. Could you update the readme to reflect this change? @mkdynamic what do you think about this?