Joe Lencioni

Results 248 comments of Joe Lencioni

Ah, I was thinking it would be nice to warn when it wasn't there for `User` events. Something like this: ``` vim silent doautocmd User MyUserCmd ``` should be: ```...

@14850842 Does this documentation help at all? https://github.com/khan/aphrodite#server-side-rendering

Is it possible that you have two different copies of Aphrodite in your bundle? Perhaps one as a nested dependency?

We have been using context to share "theme" information, like colors, fonts, breakpoints, and stuff like that. So, I recently wrote a HOC for adding styles to a component. Here's...

We have 1 HOC for every styled component. It does not extend anything. **Edit:** I'm suddenly not sure I understand what you mean by "1 HOC for every styled component"....

If you are using Aphrodite with React, I think it is good to prefer composing components over sharing styles.

I've also recently published this CSS-in-JS style guide: https://github.com/airbnb/javascript/tree/master/css-in-javascript

Opening https://github.com/airbnb/react-with-styles/pull/70 to hopefully fix the build.

@lelandrichardson yeah, I was a little on the fence but I think you are right.

I wonder if this is the same issue that @reklawnos reported here: https://github.com/Khan/aphrodite/pull/238 @ethangodt can you try the fix in that PR and see if it resolves this?