aphrodite icon indicating copy to clipboard operation
aphrodite copied to clipboard

min-content and max-content are not prefixed

Open VictorienTardif opened this issue 8 years ago • 4 comments

I wasn't understanding why my css declaration max-width:min-content wasn't working on Safari and I discovered that I had to add prefixes -webkit-min-content and moz-min-content.

I had to add all prefixes in a single css declaration like this:

'max-width':'-moz-min-content; max-width:-webkit-min-content; max-width:min-content'

VictorienTardif avatar Jun 14 '17 14:06 VictorienTardif

Aphrodite uses inline-style-prefixer for prefixing styles. It looks like they have a test that ensures that these values are prefixed. https://github.com/rofrischmann/inline-style-prefixer/blob/23d1c63b7b32c1b6ccf05f9d50b2a050766befd9/test/static/createPrefixer-test.js#L153-L158

What version of Aphrodite and inline-style-prefixer do you have installed? Also, can you provide a minimal repro case?

lencioni avatar Jun 14 '17 15:06 lencioni

weird... I have aphrodite 1.2.0. inline-style-prefixer is 3.0.3.

How can I provide a repro case?

VictorienTardif avatar Jun 14 '17 15:06 VictorienTardif

Can you verify that this is still a problem for you on the latest versions of each? Aphrodite is at 1.2.1 and inline-style-prefixer is at 3.0.6.

As for a repro case, it would be helpful if you could post some code that would surface this issue. Ideally this would be in the form of a git repo that I could clone, run npm install, and then another command (maybe npm test or npm build) that will show the issue.

lencioni avatar Jun 14 '17 15:06 lencioni

Hello, unfortunately it's the same for me with the latest versions. I'm sorry but I won't have time to set up a repo to demonstrate this issue. I just wanted to let you know that min-content is not prefixed, at least for me but I see no reason why it would be different for anyone else. Thank you for your answers.

VictorienTardif avatar Jun 15 '17 08:06 VictorienTardif