Maik Marschner

Results 174 comments of Maik Marschner

@etairi Good idea! :+1: @gunn Your first option is far too complicated imho, and the second option is just a more complicated way to configure what @etairi suggested. :wink:

Thanks a lot for using this component and for the feedback. :) 1. ~Is this a valid use case or just clicking around and seeing whether the component will explode?~...

@PorterK Same here. I wasted several hours on that. :sweat:

@Serg4554 I'm sorry I didn't see this earlier! This is an _awesome_ first contribution, thank you so much! :tada: I'd rename `cancelOnClose` to `selectOnClose`. :thinking: What do you think?

@Serg4554 No problem, I'm happy that you'll take the time to get this PR ready to merge. :)

@Serg4554 Do you still have time to finish this PR? Don't worry, I'll update it for you otherwise. :+1:

@Serg4554 Awesome! :tada: I've got this on my radar, I'll look into the tests soon (TM).

@Serg4554 Would you mind rebasing this on top of master? I'm a bit confused by all the changes right now…

@benwiley4000 This component inherits from `ImgHTMLAttributes`, so I don't really see why this is the same problem. Could you elaborate (or submit a PR)?