material-ui-search-bar icon indicating copy to clipboard operation
material-ui-search-bar copied to clipboard

Forked this project, republished and willing to help with features

Open SnekCode opened this issue 3 years ago • 7 comments

Hello,

I wanted to use this library for React 17+ and Next js but wasn't sure how to submit Pull requests in order to update features. I forked this project and converted it to 100% typescript with jest tests. I was able to publish the new package to npm!

Heres My fork If the team likes these changes lets discuss a PR.

Working to add a move left boolean prop which addresses Issue #84(Move SearchIcon to the left)

SnekCode avatar Aug 01 '21 13:08 SnekCode

Just open a PR if you want :)

leMaik avatar Aug 01 '21 17:08 leMaik

@leMaik I changed a lot but it should deploy the same, I'll open a PR and we can have discussions :)

Updated somethings today to address #84 and #86 and #106. See my GH page for examples.

SnekCode avatar Aug 04 '21 03:08 SnekCode

What's happening with the fork and PR??

binarykitchen avatar Nov 25 '21 00:11 binarykitchen

No changes to Fork or PR since my initial opening of this thread. No one has reached out to discuss the PR. Fork works with React 17+. @binarykitchen did you have any particular questions?

SnekCode avatar Nov 25 '21 01:11 SnekCode

@SnekCode I tried your package and it appears to have an issue displaying the Clear button for me.

recursiveElk avatar Dec 05 '21 22:12 recursiveElk

@recursiveElk if you can open a ticket on my repo and give an example of how you are using it I'd be glad to solve the issue :)

SnekCode avatar Dec 06 '21 03:12 SnekCode

@SnekCode I pretty much lost track with this project (we don't use it anywhere currently). Your PR looks great, I just merged another PR that brings React >=17 support.

Maybe we should just merge your PR v2.0.0 and be done with it? :thinking: Not sure what's the best way forward.

leMaik avatar Oct 17 '22 22:10 leMaik