LB (Ben Johnston)

Results 1054 comments of LB (Ben Johnston)

OK regarding `wagtailadmin/js/modal-workflow.js`, I actually think this should be imported globally, not bespoke for individual templates. Ignore my `media` comment above, I thought that could help us here for this...

I have added one more commit ea7d9a59ae113506f93ce42cc38aa96c22d23411 The tests previously were loading up a 'value' of the HTML with the resolved URLs. While this made sense if we were checking...

It seems that some projects relied on the global existing for their own custom widgets. Not sure if it's worth adding more to the release notes with an example of...

**I have asked the core team their thoughts also and will for now add needs decision label to get a bit more consensus.** My opinion is that we should just...

Discussed this today and there is a general consensus with the core team that we should revise the setting introduced in https://github.com/wagtail/wagtail/issues/11536 to be a bit more flexible (a dictionary)...

@stevejalim not sure yet, just to be clear, we will not build out this full feature yet (PR's welcome :) ), but instead just ensure we have a more flexible...

@Jaivignesh-afk let's go with aria-hidden=true as that's what was done in the previous PR https://github.com/wagtail/wagtail/pull/11465 If you find other candidates for empty elements that need fixing this same way, feel...

The hover animation is intentional but as for whether this is something that should be modified I'll leave to design. @thibaudcolas - adding to UXlId design board, I know there...

Marking as draft while I work out why prettier mirror is not mirroring. https://github.com/wagtail/wagtail/pull/11594#issuecomment-1932836096

OK this is ready to review again. I have rebased and re-tested the following; * Storybook build & run * Webpack build (dev & production) * Linting, unit tests, Typescript...