django-rest-framework icon indicating copy to clipboard operation
django-rest-framework copied to clipboard

rest_framework.urls doesn't work with LogoutView in Django 5.0

Open gaurovsoni opened this issue 1 year ago • 3 comments

In Django 5.0, GET request for logout was removed (only POST supported now) and it seems like in DRF we still do GET request to the endpoint.

https://docs.djangoproject.com/en/5.0/releases/5.0/

  • Support for logging out via GET requests in the django.contrib.auth.views.LogoutView and django.contrib.auth.views.logout_then_login() is removed.

gaurovsoni avatar Jan 03 '24 04:01 gaurovsoni

The hover animation is intentional but as for whether this is something that should be modified I'll leave to design.

@thibaudcolas - adding to UXlId design board, I know there are some changes coming down the line for the logo here.

lb- avatar Feb 11 '24 21:02 lb-

Picture - 1 : Not hovering over the div Extra - 1 Picture - 2 : Hovering over the wrapper div only Extra - 2 Picture - 3 : Hovering over the SVG Extra - 3

Is the hovering animation displayed in Picture - 2 intentional ?

Shreshth-Srivastava avatar Feb 12 '24 10:02 Shreshth-Srivastava

I believe this is intentional, as otherwise you wouldn't be able to see the easter egg when you pet the bird using the cursor.

easter egg

Edit: OK, maybe the in-between state where you only hover on the circle and not the bird is a bug:

image

But this state definitely isn't:

image

laymonage avatar Feb 12 '24 10:02 laymonage

@laymonage Should I submit a pull request for the fix now, or would it be better to wait for additional reviews ?

Shreshth-Srivastava avatar Feb 12 '24 10:02 Shreshth-Srivastava

I don't know whether removing the in-between state will make the animation less smooth, but feel free to submit a PR so we can see what it looks like. We'll discuss it with our designer soon. Thanks!

laymonage avatar Feb 12 '24 10:02 laymonage