LB (Ben Johnston)
LB (Ben Johnston)
Thanks for getting this started @vinfinity7 - I have a refinement coming to this branch to finish this off so that we can merge this in. With #11854 & https://github.com/wagtail/wagtail/pull/11582...
Hey @albinazs are you still able to pursue this PR or should we close for someone else to pick up?
New PR has been put up to rebase this https://github.com/wagtail/wagtail/pull/11756
Thanks @laymonage - happy to do a full review when ready.
@laymonage I needed the Promise handling of the `debounce` for a different PR so brought it over (hope that's ok), also refined types and added a full unit test suite....
For this, would it be possible to also put in place a deprecation of the globals? `WAGTAIL_CONFIG.WAGTAIL_AUTO_UPDATE_PREVIEW_INTERVAL` and `WAGTAIL_CONFIG.WAGTAIL_AUTO_UPDATE_PREVIEW`. Instead, we set these as data attributes within the HTML from...
Update on above - https://github.com/wagtail/wagtail/pull/11166 now includes the movement of the WAGTAIL_CONFIG.WAGTAIL_AUTO_UPDATE_PREVIEW_INTERVAL and WAGTAIL_CONFIG.WAGTAIL_AUTO_UPDATE_PREVIEW configs.
@elhussienalmasri - I have prepared this issue with a bit more detail and some other ideas on approaches. Hopefully you are up for continuing on this solution, please add comments...
Thanks for the update.
From @gasman - https://github.com/wagtail/wagtail/pull/11571#issuecomment-1927950540 > I wouldn't be opposed to moving the contents of `_editor_js.html` into the base template - along with the appropriate cleanup (such as eliminating places where...