LB (Ben Johnston)
LB (Ben Johnston)
Removing good first issue from this as it seems to be causing confusion for new contributors.
> @thibaudcolas should i implement just one genric msg @hsd2514 - I would recommend you keep one generic 'error' message but still adopt the `messages` value approach, this way we...
> @lb- got it i would work on soon , should i make a new pr ?? If that's easier for you, go for it. Just close this one and...
Epic. Flagged for another full review. Please can you look at the CI failures though quickly, hopefully it's just formatting. @hsd2514
Thank you @bruecksen but we should avoid changing the jQuery library/vendor code as it makes updating this fragile. Instead, it would be better to fix this at the TagController (Stimulus)...
Ok. Thanks for investigating, I didn't realise we'd already patched the vendor JS. I'll flag this issue in the core team chat, others may have a different opinion. Plus I'm...
Thanks for the PR @JackMorganNZ - I've flagged for a review and set the full CI to run. Could you update the description with a link to the code where...
@GoldFoylee could you please look at the CI issues, thanks for raising the PR. I'll flag for review.
As per comment on the PR. I've had to solve a similar issue in the SwapController - see https://github.com/wagtail/wagtail/pull/13401/files
@DewashishCodes @vanshkamra12 - please ensure you review the issue & related PRs before commenting questions like this. As you may see, there's already a PR up with active momentum/updates on...