LB (Ben Johnston)

Results 1054 comments of LB (Ben Johnston)

Yep. That makes sense. In the future we may expect these to be added in the html (maybe not for aria-selected). But for now we will lewn towards preserving the...

I haven't forgotten this - just have not had time to sit down and review.

Hey @the-r3aper7 how are you going with this? Did you need some guidance for next steps or any help to continue with this one?

No problems, it's honestly really amazing work here, just go step by step and you'll be fine.

Thanks for the update, no pressure, I know there's a lot here. We really appreciate you contributing this. Hope your exams are going OK.

> [TabbedInterafaceStories.tsx](https://github.com/wagtail/wagtail/blob/b8343184052768205ab87bacf83d5d11b50f59b2/wagtail/admin/templates/wagtailadmin/panels/tabbed_interface.stories.tsx) This should not need any changes, but we'll need to validate it still works after the html templates are updated. > [TabbedInterface.html](https://github.com/wagtail/wagtail/blob/8bc9eb4b4d0e6361a0339bfd34d4af757ded6b38/wagtail/admin/templates/wagtailadmin/panels/tabbed_interface.html) This will need to be updated...

@the-r3aper7 > * `wagtail/admin/templates/wagtailadmin/generic/chooser/chooser.html` * Any rich text field, then try to create a link, you will see a tabbed chooser for different link types. * Any image field, try...

Awesome. I will try to take a look in the next week or so. Maybe try to tick off the items from the checklist above just to see what's done.

Thanks @elhussienalmasri I would say it's best to push up the code you have functional, then I can take another look. If we have to make the link chooser.URLs work...

Ok. I'll be able to look at soon, good reminder about the editor JS html include. I think we may be better off using the Form media approach for including...