LB (Ben Johnston)

Results 1054 comments of LB (Ben Johnston)

I think the 6.0.1 was already there in the main branch so I will drop that commit when merging.

Thanks @dostogircse171 - we'll keep this issue open but it also has been raised on the Sphinx theme. https://github.com/wagtail/sphinx-wagtail-theme/issues/281 We thought we had fixed it in time for 6.0 but...

@gasman when possible, I would love your input on this. Let me know if you are happy with this approach or have some other ideas in mind to avoid inline...

That's super helpful @gasman thank you. Yeah I've been trying to keep my head around some of the future form stuff coming down the line. If needed we can always...

Thanks @gasman I have re-read everything again, I think your approach makes 100% sense. I have added some thoughts to the other ticket also. Not sure if that's helpful or...

@kituuu - you may be keen on looking at this one. @the-r3aper7 - it's been a while and I know you're actively involved in some other PRs.

Awesome to see the collaboration here, thanks @rohitsrma for keeping at it and Sage/Storm for bringing your knowledge and skills to the reviews.

Added to 6.0 stable 266ccea1b8e194acf234bdc5c861387ee70a3a2e (& parents)

Thanks @dkirkham & @allcaps I have updated the text as per the feedback, will rebase and push to merge shortly.