Luke Zappia
Luke Zappia
Ah, we should have thought to check if **{reticulate}** had any tricks we could steal 😸! So with this, we don't need any `convert` argument, it's just internal changes, right?...
Pinging @lshep who wanted to keep an eye on this issue
Hi @BiotechPedro Thanks for submitting **microSTASIS** :tada:! Below is my review of your package. Please reply here if anything is unclear or needs any further explanation. **What next?** Please address...
@BiotechPedro You need to push the changes you have made to the Bioconductor git server so I can review them. I will reply to some of your comments below but...
@BiotechPedro I haven't read your replies yet but I don't see any updates from the build system. Were you able to get pushing to the Bioconductor git server to work?
Hmmm...ok. When I pull from Bioconductor I can see your changes as well so git has worked but for some reason there's no build. @Bioconductor/core any ideas what might be...
No worries about the version bumping thing. It happens all the time and I should have thought of that straight away. I'll reply to the conversation about the non-code points...
@Bioconductor/core I'm happy with this from the review side but I haven't added the `accepted` tag because it is currently still on CRAN.
If this is possible an additional benefit might be being able to move `SingleCellExperiment` and `Seurat` from `Depends` to `Suggests` so people only need to install the packages they are...
Fair enough. I guess my point was if it is possible for everyone to avoid having to install both `SingleCellExperiment` and `Seurat` that would be good. When you are only...