Luke Zappia

Results 196 comments of Luke Zappia

Hi @jfanglovestats. This is looking pretty good but I have a few more comments. * It is great to support `Seurat` objects but **{Seurat}** is not a Bioconductor package. To...

> I tried to incorporate this type of object first. However, I met a problem when extracting the desired parts of the object. It seems SingleCellExperiment object has a flexible...

I haven't looked into it but I'm guessing this file uses the AnnData v0.8 format. At the moment the safest /most reliable approach is to use the Python reader. The...

Hi @GabrielHoffman That is indeed a large dataset! I think the largest I have ever tried is a few hundred thousand cells. I'm actually fairly impressed you manage to work...

I'm pretty happy with this, thanks for submitting it! I made some minor comments but they are mostly just questions I wanted some clarification on. For the CI I'm kinda...

@rcannood I made the minor changes I commented on so I think this is almost good to go. Only thing left is an error with **{anndata}** loaded that I'm not...

@rcannood I'm pretty happy this is working ok (and I have some other things I want to work on that need this) so I'm going to merge now. Thanks so...

@rcannood Do you have any other insights on this or suggestions for other solutions?

Thanks for the detailed response! I'm thinking maybe option 3 is sounding like the best solution at this stage? It's maybe the most work but should help avoid similar issues...

I think I need to play around a bit to understand this a bit better but I think adding a `convert` argument is probably the most flexible option (maybe with...