Luke Zappia

Results 196 comments of Luke Zappia

This is really up to you but my preference is towards the clearest, most explicit naming. So either the object type (if that is required) or a description of what...

> > * [ ] ⚠️ There are some notes in the build report, please check these and address as many as possible > > Thanks for pointing this out....

@lshep Can you please give us an official opinion on the size and checking time warnings in the build report? Thanks!

Thanks for your work on reducing the build time, I can see the build system is happy with it now. The only thing I'm not happy with is documenting the...

> For more context - we tried to follow the way described here -> [contributions.bioconductor.org/docs.html#doc-inst-script](https://contributions.bioconductor.org/docs.html#doc-inst-script) (specifically, §12.4 and §12.3.3) You will notice that 12.4 says _"if data was included in...

Hi @martasevilla Thanks for submitting **UPDhmm** :tada:! Below is my review of your package. Please reply here if anything is unclear or needs any further explanation. **What next?** Please address...

- A new build doesn't seem to have been triggered for some reason. Maybe you forgot to update the version number? - The `test.vcf.gz` is still present in the test...

> > * Compulsory arguments should come before optional arguments in function definitions This should be fixed in `vcfCheck()` > > * The default value for the `hmm` argument doesn't...

Congratulations on having the package accepted into Bioconductor 🎉! It can take a few days to be picked up by the build system but then it should be available in...

Hi @MicTott Thanks for submitting **SpotSweeper** :tada:! Below is my review of your package. Please reply here if anything is unclear or needs any further explanation. **What next?** Please address...