lance6716

Results 444 comments of lance6716

under `syncer` ![image](https://user-images.githubusercontent.com/1689766/93309586-481cf080-f836-11ea-9bb8-e78a7703ba6c.png)

coverage under `syncer` after https://github.com/pingcap/dm/pull/1109 ![image](https://user-images.githubusercontent.com/1689766/94511073-e94e7280-024a-11eb-9905-4e2a2b60013d.png)

> #1682 #924 this requires we couple block allow lists into go-mysql 🤔maybe we can learn native mysql replication’s balist interface

`sources[1].msg` will be filled with running status, so that's different with `list-member --source`

Hi, what's your version of TiUP and `tiup dm`? also @lucklove PTAL

currently tiup-dm doesn’t support SSL. welcome to file a feature request in pingcap/tiup

> /pick-up we're refactoring the ti-challenge-bot, I'll manually add the label for you

I have used chaosmesh to try imitate a bad disk environment, but not effective to reveal bugs. We might try use failpoint with percent probability to inject into etcd API,...

(removed the BUG label because we need further investigating if it's has been fixed)

This problem is caused by dump unit always returns true in https://github.com/pingcap/dm/blob/50841fb066119153c3b33a92ff9e57959e6ff914/dumpling/dumpling.go#L197-L199 Maybe we should check dump files in local disk