lance6716

HI, I want to contribute a feature to errcheck, that is "statement returned error variables must be checked in next statement". This is my commit https://github.com/lance6716/errcheck/commit/43c9b804f2fa62ecd9865c9f440552ecfcd07621 Now I want to...

Why this reports error for named return

2

noticed https://github.com/alexkohler/nakedret/blob/b2c01465241327a7db35ec77f94ff19168bcabaa/testdata/nested.go#L11-L17 I think this return in line 16 is not harmful, and this linter should not report error :thinking:

suite may race when its test creates goroutine

4

in testify/suite/suite_test.go ```golang // SuiteGoroutineRace is intended to test there should be no race when creating // goroutine in tests. type SuiteGoroutineRace struct{ Suite } // TestSuiteRequireTwice... func TestSuiteGoroutineRace(t *testing.T)...

schematracker: add an unit test to cover an usage

3

Signed-off-by: lance6716 ### What problem does this PR solve? Issue Number: ref https://github.com/pingcap/tidb/issues/35933 Problem Summary: ### What is changed and how it works? in DM integration tests, I found a...

Support specify row number limit per INSERT statement

1

## Feature Request **Is your feature request related to a problem? Please describe:** bytes limit per statement doesn't fit all cases, for example, one table has many columns and another...

Write more context in metadata (such as SQL Mode)

3

## Feature Request **Is your feature request related to a problem? Please describe:** mydumper's metadata has some not so good design, for example, write an empty `GTID:` when not enable...

Update partition.py

1

fix bug that `files` will be overwrite

block user accessing importing tables by RENAME TABLE

5

## Feature Request **Is your feature request related to a problem? Please describe:** When lightning is doing its job, user still can access importing tables, so he may see non-consistent...

## Feature Request **Is your feature request related to a problem? Please describe:** In some cases user may need to grep lightning's log and modify stalled checkpoint and importer's data...

Misc improvements

1

## Feature Request **Is your feature request related to a problem? Please describe:** **Describe the feature you'd like:** - [ ] io.EOF is [an ambigious error](https://github.com/grpc/grpc-go/blob/230def769105c46b2e597578b23002a6ac159dde/stream.go#L96-L99), should we retry it?...