lance6716

Results 444 comments of lance6716

Sounds great. currently DM will stop at that error so user can use [`handle-error`](https://docs.pingcap.com/tidb-data-migration/stable/handle-failed-sql-statements#handle-error) to replace that SQL, but an auto-conversion feature is definitely better. Could you give an exmaple...

> It still executes the statements even though the table exists. The error is skippable if the collation used in the table is supported. However, if the collation is not...

@namco1992 LGTM, and for incremental phase, function `handleSpecialDDLError` could be used to detect unsupported collation error and rewrite SQL

Take your time, and if you need some help you could comment here or join [sig-migrate in slack](https://slack.tidb.io/invite?team=tidb-community&channel=sig-migrate&ref=github_sig)

lgtm, and I think `dumplings` could be an alias for `mydumpers`, no need to give a warning

for 1.1, seems the failure is caused by multiple mysql instance hiding from a same IP/source-id, so there maybe mixed server_uuid/`ServerID` for a relay unit. ``` [2021/03/22 12:29:06.581 +00:00] [DEBUG]...

~~we can't start parsing a WriteRowsEvent without seeing its previous TableMapEvent~~ @GMHDBJD ``` [2021/03/24 20:04:55.985 +08:00] [DEBUG] [reader.go:548] ["start parse relay log file"] [task=test] [unit="binlog replication"] [component="binlog reader"] [file=/tmp/dm_test/new_relay/worker1/relay_log/09bec856-ba95-11ea-850a-58f2b4af5188.000001/mysql-bin.000001] [offset=1008]...

> > [2021/03/24 20:04:55.986 +08:00] [ERROR] [reader.go:557] ["parse relay log file"] [task=test] [unit="binlog replication"] [component="binlog reader"] [file=/tmp/dm_test/new_relay/worker1/relay_log/09bec856-ba95-11ea-850a-58f2b4af5188.000001/mysql-bin.000001] [offset=1008] [error="Header &replication.EventHeader{Timestamp:0x605b2ae7, EventType:0x1e, ServerID:0x1, EventSize:0x35, LogPos:0x4e8, Flags:0x0}, Data "ԑ\x00\x00\x00\x00\x01\x00\x02\x00\x02\xff\xfc\x03\x00\x00\x00\fEddard Stark", Err: table...

> I remember that parser will parse TableMapEvent and WriteEvent together, and may not stateful. good night. 🤣 We continue using same `r.parser`, so RowsEvent which is read after a...