lance6716 comments

Results 444 comments of


                                            lance6716

Proxied traffic hook

Hi, I was looking for a traffic statistics and found this issue, did you implement it already? 😁

Feature Request: When using database/sql's Rows type, rows.Err() must be called

there're other linters like https://github.com/jingyugao/rowserrcheck, https://github.com/ryanrolds/sqlclosecheck, maybe you could take a look.

Why this reports error for named return

> @lance6716 @alexkohler Why do you believe this to be a bug? This is not that severe as a bug IMO. As the README says > Naked returns are okay...

suite may race when its test creates goroutine

How about we add a `Suite.Go(func())` that wraps a wait group? And we expect user to use this helper. Our usage is in tests, we spawn a new goroutine to...

suite may race when its test creates goroutine

> cannot reproduce locally > > maybe paste complete code, some symbol is missing the snippet should be put in testify/suite/suite_test.go

Update partition.py

sorry I realised it's just a example code for custom dataset, mixed running logic for ply and las.

lightning import failed when tikv net delay 100ms

Hi, lightning's repo is https://github.com/pingcap/tidb-lightning/

security(engine): add tls support for etcd and mysql connection

https://github.com/pingcap/tiflow/pull/6913 should turn on TLS for MySQL meta store to test this feature. BTW, please help review https://github.com/pingcap/tidb/pull/37479

security(engine): add tls support for etcd and mysql connection

I forget what test I should add in https://github.com/pingcap/tiflow/pull/6913 😂

security(engine): add tls support for etcd and mysql connection

Seems we need to add configuration fields to meta about certificates, I'll do it after https://github.com/pingcap/tiflow/pull/6913 is merged because it's a bit large now