lance6716
binlog-filter in tidb-tools doesn't prepared for VIEW statements, will file PR later
waiting https://github.com/pingcap/tidb-tools/pull/405 (but I think it's OK to merge this PR before tidb-tools. In days before v2.0.1 release will update dependencies as well)
and supporting VIEW may block user's migration, such as need handle VIEW as unsynced shard DDL? should we defaultly disable this 🤔 @csuzhangxc @GMHDBJD
remember to revert VIEW part of https://github.com/pingcap/dm/pull/1331
updated code and PR description, PTAL @lichunzhu @GMHDBJD @csuzhangxc
PTAL @GMHDBJD
data race recorded in https://github.com/pingcap/dm/pull/1351 ``` [2021-01-07T04:24:29.483Z] WARNING: DATA RACE [2021-01-07T04:24:29.483Z] Write at 0x00c0002da4f0 by goroutine 194: [2021-01-07T04:24:29.483Z] github.com/pingcap/dm/pkg/gtid.(*MySQLGTIDSet).Set() [2021-01-07T04:24:29.483Z] /home/jenkins/agent/workspace/dm_ghpr_test/go/src/github.com/pingcap/dm/pkg/gtid/gtid.go:105 +0xb5 [2021-01-07T04:24:29.483Z] github.com/pingcap/dm/relay.(*Relay).handleEvents() [2021-01-07T04:24:29.483Z] /home/jenkins/agent/workspace/dm_ghpr_test/go/src/github.com/pingcap/dm/relay/relay.go:474 +0x1217 [2021-01-07T04:24:29.483Z] github.com/pingcap/dm/relay.(*Relay).process() [2021-01-07T04:24:29.483Z]...
In what case there's "MySQL has some data dumped in session sql_mode", does dumpling have this configuration 🤔
related to https://github.com/pingcap/dm/issues/1735 I think we could always mask some SQL mode, to provide better compatibility.