lance6716

Results 444 comments of lance6716

at least we should record last N skipped DDL, and downstream `dm_meta` is a good place to record

this action should be addressed in https://docs.pingcap.com/zh/tidb-data-migration/dev/shard-merge-best-practices#%E8%87%AA%E5%A2%9E%E4%B8%BB%E9%94%AE%E5%86%B2%E7%AA%81%E5%A4%84%E7%90%86 😂 currently for DELETE event DM will delete unexpected rows because of mismacthed table structure

can we remove this limit? instead, we find the sync unit in subtask.units and call OperateSchema for it. https://github.com/pingcap/dm/blob/fadd54342759286e7572bb100684fe48942c0ca7/dm/worker/subtask.go#L539-L542 @GMHDBJD This will allow user to pause the task at load...

> I still disagree let users manually pause the task and then set schema, no one will carefully read the document. 😭 Maybe an error and workaround would be better....

Thanks for your feedback, currently we didn't support turning on `log_bin_compress`. And in fact TiDB DM is built for migrating data to TiDB, for your usage of migrating to MariaDB...

> log_bin_compress may I ask if you are using MySQL or MariaDB? I found that the implementation is a little different https://dev.mysql.com/doc/refman/8.0/en/binary-log-transaction-compression.html https://mariadb.com/kb/en/compressing-events-to-reduce-size-of-the-binary-log/ since `mysqlbinlog` supports it, I agree that...

If we don't lock tables, upstream and downstream may have some different data, but not all data are different. So if split them into chunks by some good WHERE clause,...