Lars Grüter

Results 496 comments of Lars Grüter

@JoOkuma, feel free to ignore pep8speaks. See https://github.com/scikit-image/scikit-image/pull/7148.

Re https://github.com/scikit-image/scikit-image/pull/7071#issuecomment-1731602206, @JoOkuma: noted and totally okay. Thank you for the work so far! I agree with your assessment, that both results are valid watershed results. I don't remember all...

Definitely! We already agreed to do that yesterday! :blush:

Oh, then I misunderstood you? To avoid further confusion: Do you want to `skimage.img_as_float64` and others to still work but not be advertised by code completion, or included in `from...

I'm not sure whether I discovered a bug here in lazy_loader: even though `"__version__"` is included in the `__all__` attribute of the PYI file, `skimage.__all__` doesn't add runtime. *Edit: E.g....

After revisiting this, I'd suggest reverting the changes that touch `doc/source/gitwash` which is a git submodule. We are better off updating that upstream and incorporating changes that way. I'm happy...

> I can easily imagine a situation where a core developer does not have any spare time to read through GitHub notifications and respond over the course of 1-2 days...

I think the next call is when we are in Seattle? Happy to discuss it. Though, it seems like we settled on a consensus mostly, so IMO we can just...

Thanks for the report! I was able to reproduce this. It seems like we didn't create the v0.21.x branch for the last release which binder is expecting. The expectation for...

Sorry for that, it seems like we forgot to create the `v0.22.x` branch again. @jarrodmillman, could we somehow make sure that this step is not forgotten during our release process?...