Lars Grüter

Results 496 comments of Lars Grüter

I think higher peaks take precedence. The coordinates passed to `ensure_spacing` are sorted by intensity in https://github.com/scikit-image/scikit-image/blob/9b91d3aac0816eb46054629844f694f3c06d3d94/skimage/feature/peak.py#L16-L19 The "-" makes highest value go first. These are then passed to the...

I think the argument is that if someone uses the `--pre` flag then `pip install --pre numpy scikit-image` would yield a broken install once NumPy 2c comes around.

Hmm, but as we've seen already this issue can be annoying for up-stream libraries. matplotlib limiting to NumPy

Oh, we should get on that asap. @jarrodmillman, I was under the impression that 0.23.0rc0 was already built with NumPy 2.0 but local testing and CI (e.g. [this job](https://github.com/scikit-image/scikit-image/actions/runs/8396892031/job/22999233914#step:6:300)) tells...

Addressed in https://github.com/scikit-image/scikit-image/pull/7367. :rocket:

Confirmed that `pip install --pre scikit-image` pulls down NumPy 2 and `skimage.test()` passes locally. Note our optional dep astropy still pulls in NumPy

I can reproduce, thanks for the report. Seems like we are starting to see these failures only now, because PyWavelets or some other dependency is no longer blocking NumPy 2.0,...

Closing since https://github.com/scikit-image/scikit-image/pull/7320 addressed this.

Hey @Ganesh2409, this already looks much better; thank you. The CI is currently failing because the updated code in this PR doesn't pass the [check](https://results.pre-commit.ci/run/github/2014929/1703332291.GCfxFczFQJ2f2LTXGBdstg) of our code formatter. Please...

Thanks for the hint @FedericoWZhaw! https://github.com/scikit-image/scikit-image/pull/955 makes me think that that when the other angles were added the comment was just forgotten. Would you like to make a PR that...